Fix mark used API response serialization#18140
Merged
kfaraz merged 1 commit intoapache:masterfrom Jun 13, 2025
Merged
Conversation
adarshsanjeev
approved these changes
Jun 13, 2025
Contributor
Author
|
Thanks for the prompt review, @adarshsanjeev ! |
jtuglu1
pushed a commit
to jtuglu1/druid
that referenced
this pull request
Jun 17, 2025
Bug: Some APIs in `DataSourcesResource` and `OverlordDataSourcesResource` are not able to serialize out the JSON response. __Note that the API is handled correctly by the server, it just fails to send back an appropriate response.__ This bug was introduced a while back in apache#17545 While most of the APIs already handled sending back a JSON response, some APIs didn't. Fix: Update all APIs in `DataSourcesResource` and `OverlordDataSourcesResource` to handle sending back a JSON response by annotating with `@Produces(MediaType.APPLICATION_JSON)`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
For some APIs,
DataSourcesResourceandOverlordDataSourcesResourceare not able toserialize out the JSON response.
Note that the API is handled correctly by the server, it just fails to send back an appropriate response.
This bug was introduced a while back in #17545
While most of the APIs already handled sending back a JSON response,
some APIs didn't.
Fix
DataSourcesResourceandOverlordDataSourcesResourceto handlesending back a JSON response by annotating with
@Produces(MediaType.APPLICATION_JSON)Release note
Fix a bug with the following mark used / mark unused APIs so that they can send back a JSON response successfully.
Currently, these APIs work correctly but error out while sending back a response.
This PR has: