Skip to content

Update UI to account for multiple supervisor single datasource#18175

Merged
jtuglu1 merged 1 commit intoapache:masterfrom
jtuglu1:update-UI-for-multi-supervisor-single-datasource
Jul 2, 2025
Merged

Update UI to account for multiple supervisor single datasource#18175
jtuglu1 merged 1 commit intoapache:masterfrom
jtuglu1:update-UI-for-multi-supervisor-single-datasource

Conversation

@jtuglu1
Copy link
Copy Markdown
Contributor

@jtuglu1 jtuglu1 commented Jun 26, 2025

Follow-up to #18082.

Description

Updates the supervisor view UI to include the datasource column in the sys.supervisors table, as well as ensures the id field in the root of an ingestion spec is always rendered in the spec view/edit window.

Screenshot 2025-06-27 at 9 00 29 AM

Screenshot 2025-06-30 at 11 10 03 AM

Release note

Update UI to account for multiple supervisor single datasource



This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@jtuglu1 jtuglu1 force-pushed the update-UI-for-multi-supervisor-single-datasource branch 2 times, most recently from 0fa18d4 to e2b7c64 Compare June 26, 2025 05:36
@jtuglu1 jtuglu1 changed the title Update UI to account for multiple supervisors ingesting into same dat… Update UI to account for multiple supervisor single datasource Jun 26, 2025
@vogievetsky
Copy link
Copy Markdown
Contributor

Is this in response to some backend change that allows multiple supervisors for a datasource? If so can you link it please?

@kfaraz
Copy link
Copy Markdown
Contributor

kfaraz commented Jun 26, 2025

@vogievetsky , this is the PR:
#18082

@jtuglu-netflix , please add this to the PR description as well.

@jtuglu1 jtuglu1 force-pushed the update-UI-for-multi-supervisor-single-datasource branch from e2b7c64 to d4a2a46 Compare June 26, 2025 13:33
@jtuglu1 jtuglu1 marked this pull request as ready for review June 26, 2025 13:56
@jtuglu1 jtuglu1 force-pushed the update-UI-for-multi-supervisor-single-datasource branch from d4a2a46 to 7b9c14d Compare June 26, 2025 15:09
@jtuglu1 jtuglu1 force-pushed the update-UI-for-multi-supervisor-single-datasource branch from 7b9c14d to 94625c9 Compare June 26, 2025 15:47
@jtuglu1 jtuglu1 requested review from kfaraz and vogievetsky June 27, 2025 16:05
@kfaraz kfaraz added this to the 34.0.0 milestone Jul 2, 2025
Copy link
Copy Markdown
Contributor

@kfaraz kfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified using an embedded-test.

Screenshot 2025-07-02 at 8 30 47 PM

Looks good to me.

@jtuglu1 jtuglu1 merged commit 85a94ca into apache:master Jul 2, 2025
10 checks passed
@jtuglu1 jtuglu1 deleted the update-UI-for-multi-supervisor-single-datasource branch August 22, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants