Skip to content

Revert a change in #18136#18222

Merged
FrankChen021 merged 1 commit intoapache:masterfrom
FrankChen021:revert
Jul 9, 2025
Merged

Revert a change in #18136#18222
FrankChen021 merged 1 commit intoapache:masterfrom
FrankChen021:revert

Conversation

@FrankChen021
Copy link
Copy Markdown
Member

@FrankChen021 FrankChen021 commented Jul 9, 2025

Description

Solve the comment: #18136 (comment)

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@cryptoe cryptoe added this to the 34.0.0 milestone Jul 9, 2025
@FrankChen021
Copy link
Copy Markdown
Member Author

FrankChen021 commented Jul 9, 2025

merged although one Unit & Integration tests was cancelled after long time running.it's not relavent to this change.

@FrankChen021 FrankChen021 merged commit 917e888 into apache:master Jul 9, 2025
31 of 32 checks passed
@FrankChen021 FrankChen021 deleted the revert branch July 9, 2025 08:27
capistrant pushed a commit to capistrant/incubator-druid that referenced this pull request Jul 13, 2025
@FrankChen021 @capistrant
Revert a change (apache#18222)
6e4376e
@capistrant capistrant mentioned this pull request Jul 13, 2025
Closed
capistrant pushed a commit to capistrant/incubator-druid that referenced this pull request Jul 16, 2025
@FrankChen021 @capistrant
Revert a change (apache#18222)
e0e2842
@capistrant capistrant mentioned this pull request Jul 16, 2025
Merged
capistrant added a commit that referenced this pull request Jul 16, 2025
@capistrant @FrankChen021
Revert a change (#18222) (#18266)
cc93015 
Co-authored-by: Frank Chen <frank.chen021@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cryptoe cryptoe cryptoe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

34.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@FrankChen021 @cryptoe