add examples for duration and period granularities

[guobingkun]

add examples for duration and period granularities

[rasahner]

Thanks for the examples.

While you're in this file, perhaps you could add a period at the end of the sentence "Supported granularity strings are: ..."

Also, it would be nice (and more consistent) to provide an example under "Simple Granularities" like the ones for the other granularity types. That might help show why the specification is described as being given by a string or an object - I was initially confused about what "object" means in this context.

[pjain1]

👍

[xvrl]

+1 for adding examples to the other "simple" granularity types. Alternatively, you can just indicate what the string types are equivalent to (except none and all for which it doesn't really make sense to give the object form)

[drcrallen]

As a general note in case some DEV stumbles here later, io.druid.segment.incremental.IncrementalIndex#getInterval currently does this.gran.next(this.getMaxTimeMillis()) to find the end time. As such, if you have ALL query granularity getInterval() will return an interval whose end time is JodaUtils.MAX_INSTANT

Found that one the hard way the other day.

[guobingkun]

Done adding the period and adding examples to "simple" granularity.

[rasahner]

Thanks. LGTM.

[drcrallen]

👍

[himanshug]

can you change the interval also to America/Los_Angeles timezone? that would be the common use case.

[guobingkun]

Done.