ShimCursor: Fix dimension selectors on non-strings.#18371
Merged
cryptoe merged 1 commit intoapache:masterfrom Aug 6, 2025
Merged
ShimCursor: Fix dimension selectors on non-strings.#18371cryptoe merged 1 commit intoapache:masterfrom
cryptoe merged 1 commit intoapache:masterfrom
Conversation
Follow-up to apache#18305. Fixes a bug where calling ShimCursor's makeDimensionSelector on a non-string type would throw an error. Now, it has behavior similar to QueryableIndexCursor: - Uses ValueTypes.makeNumericWrappingDimensionSelector on numeric types, casting the numbers to strings. - Returns a nil selector for array and complex types. The new tests verify selector compatibility more extensively.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| dimensionSpec, | ||
| spec -> { | ||
| if (spec.mustDecorate()) { | ||
| if (spec.mustDecorate() || spec.getExtractionFn() != null) { |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
adarshsanjeev
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #18305. Fixes a bug where calling
ShimCursor'smakeDimensionSelectoron a non-string type would throw an error. Now, it has behavior similar toQueryableIndexCursor:ValueTypes.makeNumericWrappingDimensionSelectoron numeric types, casting the numbers to strings.The new tests verify selector compatibility more extensively.