Skip to content

Adding more logging in case of segment processing failed in MSQ. #18378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cryptoe merged 3 commits into from
Aug 7, 2025
Merged

Adding more logging in case of segment processing failed in MSQ. #18378

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d866e74
Adding more logging in case of segment processing failed in MSQ.
cryptoe Aug 7, 2025
8ac4f87
Minor language tweaks
cryptoe Aug 7, 2025
9705198
Message templating.
cryptoe Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...multi-stage-query/src/main/java/org/apache/druid/msq/querykit/BaseLeafFrameProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import org.apache.druid.frame.read.FrameReader;
import org.apache.druid.frame.write.FrameWriterFactory;
import org.apache.druid.java.util.common.Unit;
import org.apache.druid.java.util.common.logger.Logger;
import org.apache.druid.msq.exec.DataServerQueryHandler;
import org.apache.druid.msq.input.ReadableInput;
import org.apache.druid.msq.input.table.SegmentWithDescriptor;
Expand All @@ -44,6 +45,7 @@

public abstract class BaseLeafFrameProcessor implements FrameProcessor<Object>
{
private static final Logger log = new Logger(BaseLeafFrameProcessor.class);
private final ReadableInput baseInput;
private final ResourceHolder<WritableFrameChannel> outputChannelHolder;
private final ResourceHolder<FrameWriterFactory> frameWriterFactoryHolder;
Expand Down Expand Up @@ -85,7 +87,14 @@ public ReturnOrAwait<Object> runIncrementally(final IntSet readableInputs) throw
final ReturnOrAwait retVal;

if (baseInput.hasSegment()) {
retVal = runWithSegment(baseInput.getSegment());
try {
retVal = runWithSegment(baseInput.getSegment());
}
catch (Exception e) {
// Did not want to load the segment for exception handling, hence adding the descriptor in the log to figure out failures.
log.error("Error processing segment descriptor: [%s]", baseInput.getSegment().getDescriptor());
throw e;
}
} else if (baseInput.hasDataServerQuery()) {
retVal = runWithDataServerQuery(baseInput.getDataServerQuery());
} else {
Expand Down
Loading