Make multi-stage-query (MSQ engine) a core capability of Druid rather than an extension#18391
Closed
kfaraz wants to merge 1 commit intoapache:masterfrom
Closed
Make multi-stage-query (MSQ engine) a core capability of Druid rather than an extension#18391kfaraz wants to merge 1 commit intoapache:masterfrom
kfaraz wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
Closing in favor of #18394 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Druid MSQ engine offers a very convenient method of performing SQL-based batch ingestion, export, etc.
Given the importance and heavy adoption of MSQ, this patch converts MSQ into a core capability of Druid
rather than an extension, as was always intended.
Changes
servicesmodule without renaming the packageorg.apache.druid.guice.DruidModuletoservices/src/main/resources/META-INF/servicescommon.runtime.propertiesfilesAlternative
Instead of moving everything to
services, the alternative was to simply move themulti-stage-querymodule into a top-level module but that wouldlead to cyclic dependencies between
servicesandmulti-stage-querysince:a) multi-stage-query depends on services for various classes
b) services is the entry point and must depend on all the core modules that need to be on the classpath
Pending
Future
servicesmodule into more appropriate modules such asprocessing,server,indexing-serviceorsqlas applicable.Release note
druid-multi-stage-queryfromdruid.extensions.loadListincommon.runtime.properties.Upgrade notes
While upgrading, the extension
druid-multi-stage-querymust be removed fromdruid.extensions.loadList.Otherwise, Druid services would fail to start as they would not be able to locate this extension.
This PR has: