-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Jetty12 (Jakarta EE8) upgrade #18424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
ffdf8ee
jetty 10 upgrade
capistrant f4eef97
checkpoint
capistrant 63f23c9
compiling but broken cuz of at least one dep calcite depending on jetty9
capistrant 87e216d
Fix breakage in router
capistrant c675117
Merge branch 'master' into jetty-update-august
capistrant acaf869
Compilation fixes after merging master in. plus getting checkstyle fi…
capistrant a741929
Remove some of the avatica deps blocking jetty12
capistrant 2536394
bump jetty to latest and fixup licenses.yaml
capistrant 067b84b
Merge branch 'master' into jetty12-ee8-upgrade
capistrant a7a0134
fixup after merging master
capistrant aba3dd0
Fixup some licenses reporting issues
capistrant 8042ece
remove jetty dependency from indexing hadoop in attempt to keep it alive
capistrant 11d2964
stop doing static checks and build with jdk11
capistrant 5f9ee32
Modifications to index_hadoop to try and keep it alive
capistrant 1f13540
Modify duplicate header removal strategy
capistrant 74f5c09
Remove dependency on non public jetty nested packages
capistrant 97e7649
Revert back to verbose and dirty Injector setup to get hadoop index f…
capistrant 0e08e10
Fix http trailers for QueryResultPusher
capistrant d2a5903
Fix trailer related tests in QueryResourceTest
capistrant 8ddb910
add some UTs
capistrant a2a224d
prevent banned dep from getting pulled in
capistrant 8d9eb66
Run rewrite rules mvn goal to fixup test files
capistrant 3660520
stop accounting for buggy mock impl in sql test
capistrant 13e4f5c
Add new http server config for Jetty UriCompliance mode. Default to a…
capistrant 6e8e5f5
fix import order
capistrant a66e475
fix spell checker flag
capistrant 9fb989d
Fixup java docs links to use java17
capistrant bdf6790
Unify approach to jetty handler for avatica json and protobuf
capistrant 99b0ebc
use 405 response code for avatica jdbc non post requests
capistrant 7aa43aa
fix checkstyle
capistrant 3f248f9
Merge branch 'master' into jetty12-ee8-upgrade
capistrant de76acc
Add link for new jetty related config
capistrant dec75f0
fix grammar in java support doc
capistrant bafb2fc
Make the legacy ITs easier to run in a wider variety of docker steps
capistrant 4ba80aa
Cleanup some of the Injector initialization code for hadoop tasks, ba…
capistrant 36949b1
Starting point for creating a DruidAvaticaHandler base class
capistrant f154b04
Share a little bit of the code between the avatica handlers
capistrant 4506aac
Work to fix AvaticaHandler constructor issues
capistrant d2ac8b7
Fix codeql flag
capistrant 2ada34f
Revert "Make the legacy ITs easier to run in a wider variety of docke…
capistrant 24f4c13
Add RequestLogger configuration back using proper jetty12 mechanism
capistrant a3bf74a
Fix checkstyle
capistrant 7b352db
Merge branch 'master' into jetty12-ee8-upgrade
capistrant 0b88098
fix import order
capistrant a907ba7
Address review comments
capistrant 73eab18
fix serialization
capistrant 0f67db8
Merge branch 'master' into jetty12-ee8-upgrade
capistrant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you still see these if you don't add the stuff, are we just assuming that people are used to it by now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ehh that was probably me just seeing Java 11 and not Java 11+ and hitting delete. I'll confirm it is still there and add back without the explicit java 11 part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually maybe removing them is right if java 17 is actually throwing exceptions without them like we indicate on line 66