Merged
Conversation
This is useful for reading entire lines for later processing. For example, it can be used to read newline-delimited JSON into a single nested column, by combining this input format with the TRY_PARSE_JSON function.
abhishekrb19
approved these changes
Aug 26, 2025
Contributor
abhishekrb19
left a comment
abhishekrb19
left a comment
There was a problem hiding this comment.
👍
It will be good to add web-console support for this feature separately.
| return size * CompressionUtils.COMPRESSED_TEXT_WEIGHT_FACTOR; | ||
| } | ||
| return size; | ||
| return size * CompressionUtils.estimatedCompressionFactor(CompressionUtils.Format.fromFileName(path)); |
Contributor
There was a problem hiding this comment.
Perhaps we can extend CompressionUtils.estimatedCompressionFactor() or add a thin wrapper that accepts the path directly and returns the compression factor - internally invoking CompressionUtils.Format.fromFileName()
Contributor
Author
There was a problem hiding this comment.
IMO these are equivalently useful for what we need them for right now, so I'll keep it the way I had it.
Contributor
Author
There was a problem hiding this comment.
thanks for reviewing!
abhishekrb19
added
the
Needs web console change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for reading entire lines for later processing. For example, it can be used to read newline-delimited JSON into a single nested column, by combining this input format with the
TRY_PARSE_JSONfunction.