allow queries with filtered aggs to match unfiltered projection aggs as long as the filter required columns are present#18535
Merged
clintropolis merged 2 commits intoapache:masterfrom Sep 18, 2025
Conversation
…as long as the filter required columns are present
cecemei
approved these changes
Sep 18, 2025
| } | ||
| boolean allMatch = true; | ||
| for (AggregatorFactory queryAgg : queryCursorBuildSpec.getAggregators()) { | ||
| AggregatorFactory filterAgg = null; |
Contributor
There was a problem hiding this comment.
nit: maybe can move FilteredAggregatorFactory filteredQueryAgg up here and check null for that instead
Member
Author
There was a problem hiding this comment.
it needs to go after the check for exact aggregator match because we would prefer an exact match in case the projection itself defined a filtered aggregator, so this is a fallback to see if a query filtered aggregator can use a non-filtered agg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Queries with filtered aggregators can use projections which have unfiltered versions of those same aggs as long as the projection also has the columns present to be able to satisfy evaluating the filter.