Skip to content

Fix flakiness in embedded tests#18583

Merged
cryptoe merged 8 commits intoapache:masterfrom
kfaraz:fix_et_timeout
Sep 29, 2025
Merged

Fix flakiness in embedded tests#18583
cryptoe merged 8 commits intoapache:masterfrom
kfaraz:fix_et_timeout

Conversation

@kfaraz
Copy link
Copy Markdown
Contributor

@kfaraz kfaraz commented Sep 27, 2025

Sample failure run

Changes

  • Maintain a boolean syncedAtleastOnce in WorkerHolder
  • Use this instead of syncer.isInitialized() to avoid 1 minute delay in worker assignment which causes flakiness
  • Increase timeout in some tests to remove flakiness

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kfaraz kfaraz changed the title [WIP][DO NOT MERGE] Add log lines to suss out timeout issues in embedded tests Fix flakiness in embedded tests Sep 29, 2025
@kfaraz kfaraz requested a review from capistrant September 29, 2025 02:40
@kfaraz
Copy link
Copy Markdown
Contributor Author

kfaraz commented Sep 29, 2025

No embedded test failure seen in the last few runs.

@cryptoe cryptoe merged commit ebd7547 into apache:master Sep 29, 2025
102 of 104 checks passed
@kfaraz kfaraz deleted the fix_et_timeout branch September 29, 2025 09:24
@cecemei cecemei added this to the 35.0.0 milestone Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants