Add sessionToken support for S3InputSource#18609
Merged
jtuglu1 merged 5 commits intoapache:masterfrom Oct 9, 2025
Merged
Conversation
jtuglu1
force-pushed
the
add-session-token-support-for-s3-input-source
branch
from
439dd50 to
78aa53d
Compare
github-actions
Bot
added
the
Area - MSQ
kfaraz
reviewed
Oct 9, 2025
Contributor
kfaraz
left a comment
kfaraz
left a comment
There was a problem hiding this comment.
Looks good, left some minor suggestions.
jtuglu1
force-pushed
the
add-session-token-support-for-s3-input-source
branch
from
618ea23 to
dbba27f
Compare
maytasm
approved these changes
Oct 9, 2025
jtuglu1
force-pushed
the
add-session-token-support-for-s3-input-source
branch
from
dbba27f to
5697cfa
Compare
cecemei
pushed a commit
to cecemei/druid
that referenced
this pull request
Oct 16, 2025
Allows Druid to use an AWS_SESSION_TOKEN (and skip assuming a role to fetch a token) if provided in the spec. No explicit assumptions are made with the input (e.g. that adding sessionToken and assumeRoleAre are mutually exclusive). This support falls in line with how other engines use things like external catalogs, etc. to vend temporary credentials to access S3, while leaving things like the exact ARN opaque to the caller.
cecemei
pushed a commit
that referenced
this pull request
Oct 17, 2025
Allows Druid to use an AWS_SESSION_TOKEN (and skip assuming a role to fetch a token) if provided in the spec. No explicit assumptions are made with the input (e.g. that adding sessionToken and assumeRoleAre are mutually exclusive). This support falls in line with how other engines use things like external catalogs, etc. to vend temporary credentials to access S3, while leaving things like the exact ARN opaque to the caller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows Druid to use an
AWS_SESSION_TOKEN(and skip assuming a role to fetch a token) if provided in the spec. No explicit assumptions are made with the input (e.g. that adding sessionToken and assumeRoleAre are mutually exclusive).This support falls in line with how other engines use things like external catalogs, etc. to vend temporary credentials to access S3, while leaving things like the exact ARN opaque to the caller.
Release note
Add sessionToken support for S3InputSource
This PR has: