Allow configuration to disable SNI Host checking (defaulted to enabled)#18623
Merged
gianm merged 3 commits intoapache:masterfrom Oct 10, 2025
Merged
Allow configuration to disable SNI Host checking (defaulted to enabled)#18623gianm merged 3 commits intoapache:masterfrom
gianm merged 3 commits intoapache:masterfrom
Conversation
clintropolis
approved these changes
Oct 10, 2025
gianm
approved these changes
Oct 10, 2025
cecemei
pushed a commit
to cecemei/druid
that referenced
this pull request
Oct 16, 2025
…d) (apache#18623) * all operator to ignore SNI host checking if they must * document new config * Add SNI to dictionary
cecemei
pushed a commit
that referenced
this pull request
Oct 17, 2025
…d) (#18623) * all operator to ignore SNI host checking if they must * document new config * Add SNI to dictionary
10 tasks
ashibhardwaj
added a commit
to confluentinc/druid
that referenced
this pull request
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some testing of the upcoming release of Druid 35 uncovered a potential breaking change in the release. #18424 upgraded from jetty 9.x to 12.x. One change in this upgrade appears to be how SNI Host checking is handled by Jetty servers. In Jetty9, if there was one certificate in the keystore, SNI Host check was actually skipped by the server. This skip is no longer happening, so situations like trying to connect with
localhostthat used to work, will now get a 400 response from the server. Overall this change is reasonable by the jetty team, but to allow for some wiggle-room for operators in the Druid 35 upgrade, we have decided to make SNI Host checking by jetty servers opt-out. This means by default, when you upgrade your cluster (if using TLS) will perform strict SNI host checks. If you choose to opt out, you should do so with caution and with a plan to get back to the default config.Release note
this should be a part of the jetty12 section of the notes
Jetty 12 servers now do strict SNI Host checks when TLS is enabled. If the host your client is connecting to the server with does not match what is in the keystore, even if there is only one certificate in that keystore, it will return a 400 response. This could impact some use cases, such as folks connecting over localhost for whatever reason. If this change will break your deployment, you can opt-out of the change by setting
druid.server.http.enforceStrictSNIHostCheckingtofalsein the runtime.properties for some or all of your Druid services. It is recommended that you modify your client behavior to accommodate this change in jetty instead of overriding the config whenever possible.Key changed/added classes in this PR
ServerConfigJettyServerModuleThis PR has: