Ignore all exceptions when pushing task logs#18748
Merged
abhishekrb19 merged 3 commits intoapache:masterfrom Nov 21, 2025
Merged
Ignore all exceptions when pushing task logs#18748abhishekrb19 merged 3 commits intoapache:masterfrom
abhishekrb19 merged 3 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@GWphua @FrankChen021 Could you take a look at this one when you get the chance? Thanks! |
FrankChen021
approved these changes
Nov 18, 2025
Contributor
|
Closing and reopening to retrigger CI checks |
Contributor
|
Thanks for the fix and test, @aho135! The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A small follow up to #18210
18210 was more targeted toward HdfsTaskLogs which throws an IOException. We experienced the same issue but with S3TaskLogs which can throw a RuntimeException
Here is a sample stack trace
Release note
Ingestion tasks will no longer fail if the task log upload fails with any exception
Key changed/added classes in this PR
ForkingTaskRunnerThis PR has: