fix leaky segment reference on segment drop#18782
Merged
gianm merged 3 commits intoapache:masterfrom Nov 29, 2025
Merged
Conversation
cecemei
approved these changes
Nov 27, 2025
| try (final Closer closer = Closer.create()) { | ||
| final Optional<Segment> oldSegment = cacheManager.acquireCachedSegment(oldSegmentRef); | ||
| long numberOfRows = oldSegment.map(segment -> { | ||
| closer.register(segment); |
Contributor
There was a problem hiding this comment.
minor nit: the oldSegment.map here seems a bit unnecessary, could be more readable if use simple if oldSegment.isPresent()
Contributor
There was a problem hiding this comment.
To me the structure seems reasonable, since for regular segments it is doing return countInspector.getNumRows() and the return val numberOfRows ends up going to the dataSourceState.removeSegment call.
Comment on lines
+131
to
+134
| public int getNumRows() | ||
| { | ||
| return 1234; | ||
| } |
gianm
approved these changes
Nov 29, 2025
clintropolis
added a commit
that referenced
this pull request
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an unfortunate bug where we leak segment references on dropping segments, preventing them from actually being dropped - the files are deleted on disk, but the buffer is not unmapped since it is tied to reference counter, so the fd is held open until the process restarts. Affects version 35, so probably need to do a patch release.