Skip to content

Web console: better formatting for Available processors header #18828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vogievetsky merged 2 commits into from
Dec 10, 2025
Merged

Web console: better formatting for Available processors header #18828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e503b7
better formatting for Available processors header
vogievetsky Dec 10, 2025
2c8108a
update tests
vogievetsky Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion web-console/src/react-table/react-table-extra.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@

.ReactTable {
&.centered-table {
.rt-th,
.rt-th {
align-content: start;
}

.rt-td {
align-content: center;
}
Expand Down
10 changes: 7 additions & 3 deletions web-console/src/views/services-view/__snapshots__/services-view.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ exports[`ServicesView renders data 1`] = `
"Usage",
"Start time",
"Version",
"CPU processors",
"Available processors",
"Total memory",
"Labels",
"Detail",
Expand Down Expand Up @@ -225,12 +225,16 @@ exports[`ServicesView renders data 1`] = `
{
"Aggregated": [Function],
"Cell": [Function],
"Header": "CPU processors",
"Header": <React.Fragment>
Available
<br />
processors
</React.Fragment>,
"accessor": "available_processors",
"className": "padded",
"filterable": false,
"show": true,
"width": 120,
"width": 100,
},
{
"Aggregated": [Function],
Expand Down
12 changes: 7 additions & 5 deletions web-console/src/views/services-view/services-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ import {
formatBytesCompact,
formatDate,
formatDurationWithMsIfNeeded,
formatInteger,
getApiArray,
hasOverlayOpen,
LocalStorageBackedVisibility,
Expand All @@ -67,6 +68,7 @@ import {
QueryManager,
QueryState,
ResultWithAuxiliaryWork,
twoLines,
} from '../../utils';
import type { BasicAction } from '../../utils/basic-action';
import { TableFilter, TableFilters } from '../../utils/table-filters';
Expand All @@ -87,7 +89,7 @@ const TABLE_COLUMNS_BY_MODE: Record<CapabilitiesMode, TableColumnSelectorColumn[
'Usage',
'Start time',
'Version',
'CPU processors',
'Available processors',
'Total memory',
'Labels',
'Detail',
Expand Down Expand Up @@ -672,13 +674,13 @@ ORDER BY
Aggregated: () => '',
},
{
Header: 'CPU processors',
show: visibleColumns.shown('CPU processors'),
Header: twoLines('Available', 'processors'),
show: visibleColumns.shown('Available processors'),
accessor: 'available_processors',
className: 'padded',
filterable: false,
width: 120,
Cell: ({ value }) => (value === null ? '' : value),
width: 100,
Cell: ({ value }) => (value === null ? '' : formatInteger(value)),
Aggregated: ({ subRows }) => {
const originalRows: ServiceResultRow[] = subRows.map(r => r._original);
const totalAvailableProcessors = sum(originalRows, s => s.available_processors);
Expand Down
Loading