Create cost autoscaler documentation, cleanup stream supervisor tests#18904
Merged
cryptoe merged 3 commits intoapache:masterfrom Jan 13, 2026
Merged
Create cost autoscaler documentation, cleanup stream supervisor tests#18904cryptoe merged 3 commits intoapache:masterfrom
cryptoe merged 3 commits intoapache:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @Override | ||
| protected OrderedSequenceNumber<String> makeSequenceNumber(String seq, boolean isExclusive) | ||
| { | ||
| return new OrderedSequenceNumber<>(seq, isExclusive) |
Check warning
Code scanning / CodeQL
Inconsistent compareTo Warning test
| EasyMock.expect(spec.getId()).andReturn(SUPERVISOR).anyTimes(); | ||
| EasyMock.expect(spec.getSupervisorStateManagerConfig()).andReturn(supervisorConfig).anyTimes(); | ||
| EasyMock.expect(spec.getDataSchema()).andReturn(getDataSchema()).anyTimes(); | ||
| EasyMock.expect(spec.getDataSchema()).andReturn(getDataSchema(DATASOURCE)).anyTimes(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note test
kfaraz
approved these changes
Jan 12, 2026
Contributor
kfaraz
left a comment
kfaraz
left a comment
There was a problem hiding this comment.
Looks good, minor doc suggestions.
Contributor
Author
|
@kfaraz or @clintropolis I will be grateful if you re-try this silly failed job. Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This patch creates missing cost-based autoscaler documentation and makes a cleanup in stream supervisor's test directory, as discussed here, but with small adjustment: I decided to not to merge changed test classes, because having them separated seems more cleaner; also it follows 'separation of concens' principle, which I respect a lot.
This PR has: