Fix reference to INDEX_MAKER in IndexGeneratorJob.#1925
Conversation
|
I don't think that's a "fix" so much as it is a "change hadoop to use IndexMerger" |
|
@drcrallen this method was using IndexMerger before #1895, which unintentionally changed it to use IndexMaker |
|
nooo.... that PR moved the persist method above it from maker to merger. you are now also moving the merge method from maker to merger. |
|
@drcrallen the intent of that PR was to remove LegacyIndexGeneratorJob and make IndexGeneratorJob behave like LegacyIndexGeneratorJob did. see also this if statement that was removed: https://github.com/druid-io/druid/pull/1895/files#diff-0c9aca6f2536c742356ddc0bae3df945L68 "isPersistInHeap" would always be false (because it wasn't documented) so LegacyIndexGeneratorJob would always have got used. So #1895 was trying to collapse those without changing any behavior, by adjusting IndexGeneratorJob to behave like LegacyIndexGeneratorJob did. But this method got missed. |
|
👍 |
|
@gianm much better explanation, thanks! |
|
👍 after travis |
Fix reference to INDEX_MAKER in IndexGeneratorJob.
Fix reference missed in #1895