Move Jackson Guice adapters into io.druid#1940
Merged
gianm merged 1 commit intoapache:masterfrom Nov 9, 2015
Merged
Conversation
* Removes access to protected methods in com.fasterxml * Eliminates druid-common's use of foreign package com.fasterxml
Contributor
Author
There was a problem hiding this comment.
This line did change, no other changes to the actual logic.
Contributor
|
|
Contributor
|
👍 Looks like this was added in 2.3 by: FasterXML/jackson-databind@5309174 |
Contributor
|
👍 (after travis) |
gianm
added a commit
that referenced
this pull request
Nov 9, 2015
Move Jackson Guice adapters into io.druid
himanshug
added a commit
that referenced
this pull request
Nov 19, 2015
[BACKPORT #1940]Move Jackson Guice adapters into io.druid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case where druid is loaded as a library in an framework that already loads Jackson, if the fasterxml classes and the druid classes are loaded by different classloaders, the protected method access will fail on the druid side. This PR prevents such protected method access by using public methods which were probably not present when the files were first written.
A MORE COMPLETE solution would probably be to migrate to https://github.com/FasterXML/jackson-module-guice at some point in the near future.