support multiple intervals in dataSource inputSpec

[himanshug]

so that users can read data from multiple intervals from input dataSource

[xvrl]

list of strings

[himanshug]

changed

[gianm]

Please use full words too!

[himanshug]

done

[xvrl]

👍

[gianm]

This could potentially return the same segments multiple times, I think. Is that bad?

[gianm]

I'm thinking of the case where two of the intervals in the list both partially overlap the same segment.

[gianm]

Or even if two intervals in the list overlap each other.

[gianm]

Perhaps add a test for that?

[himanshug]

good catch.
but, it wouldn't matter because list of intervals is always list of "disjoint" intervals ensured by calling JodaUtils.condenseIntervals(..). In case of 2 intervals overlapping same segment, this would have given same segment twice, which again wouldn't matter because caller uses "windowed" segments appropriately.
however, that looks weird from api perspective so updated the code to remove duplicates and also updated the test case to verify same.

[gianm]

@himanshug looks like a legitimate ci failure. Could you fix that and squash the commits? 👍 from me after that, everything else looks good

[ERROR] /home/travis/build/druid-io/druid/indexing-service/src/test/java/io/druid/indexing/test/TestIndexerMetadataStorageCoordinator.java:[35,8] io.druid.indexing.test.TestIndexerMetadataStorageCoordinator is not abstract and does not override abstract method getUsedSegmentsForIntervals(java.lang.String,java.util.List<org.joda.time.Interval>) in io.druid.indexing.overlord.IndexerMetadataStorageCoordinator

[himanshug]

@gianm ah that happened due to rebase not updating a new class. fixed