remove min/max aggregator factory #1999
Merged
guobingkun merged 1 commit intoapache:masterfrom Dec 18, 2015
Merged
Conversation
Member
|
Have we officially deprecated them in the docs? We didn't put anything in any previous release notes about deprecating them. I would suggest we make a clear effort to message the deprecation in the next release before removing them. |
Contributor
Author
|
@xvrl how about putting the messaging of deprecation in 0.8.3 release and then removing in 0.9.0 ? |
Member
|
@himanshug that sounds like a plan, unless of course we plan to one day have type-agnostic operators in which case we could just leave things in until then :) |
Contributor
Author
himanshug
force-pushed
the
remove_min_max_aggs
branch
from
11df29a to
1fcbc77
Compare
…x] aggregator factories
himanshug
force-pushed
the
remove_min_max_aggs
branch
from
1fcbc77 to
431469e
Compare
Contributor
Author
|
deprecation has been noted in 0.8.3 release notes, so this is safe to be merged. |
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
guobingkun
pushed a commit
that referenced
this pull request
Dec 18, 2015
remove min/max aggregator factory
seoeun25
pushed a commit
to seoeun25/incubator-druid
that referenced
this pull request
Jan 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
they have been replaced by double[min/max] . we've supported both for transitioning in past few releases.