Merged
Conversation
Contributor
|
👍 |
Member
|
Can we add a comment requesting people to clean up the java-docs, so we can remove this at some point? |
Contributor
Author
|
@xvrl comment to where? |
xvrl
added a commit
that referenced
this pull request
Dec 4, 2015
Disable javadoc linting. [Backport #2036]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
mvn javadoc:javadocwork on java 8.This may mean that releases need to be done with java 8 (I don't think this option exists in java 7's javadoc), but we are still targeting java 7 due to
target=1.7in oss-parent so I think that is fine.