Skip to content

Fix InitializationTest #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gianm merged 1 commit into from
Dec 9, 2015
Merged

Fix InitializationTest #2067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions server/src/test/java/io/druid/initialization/InitializationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,20 @@ public void testGetLoadedModules()
}

@Test
public void testGetExtensionFilesToLoad_non_exist_extensions_dir()
public void testGetExtensionFilesToLoad_non_exist_extensions_dir() throws IOException
{
final File tmpDir = temporaryFolder.newFolder();
Assert.assertTrue("could not create missing folder", !tmpDir.exists() || tmpDir.delete());
Assert.assertArrayEquals(
"Non-exist root extensionsDir should return emply array of File",
Copy link
Copy Markdown
Contributor

@rasahner rasahner Dec 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emply? empty?
(appears on other lines also)

Copy link
Copy Markdown
Contributor

@guobingkun guobingkun Dec 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch! Sent #2068.

new File[]{},
Initialization.getExtensionFilesToLoad(new ExtensionsConfig())
Initialization.getExtensionFilesToLoad(new ExtensionsConfig(){
@Override
public String getDirectory()
{
return tmpDir.getAbsolutePath();
}
})
);
}

Expand Down Expand Up @@ -227,7 +235,7 @@ public String getDirectory()
Assert.assertArrayEquals(
"Empty root extensionsDir should return emply array of File",
new File[]{},
Initialization.getExtensionFilesToLoad(new ExtensionsConfig())
Initialization.getExtensionFilesToLoad(config)
);
}

Expand Down