Skip to content

Fix all transient test failures#2165

Merged
binlijin merged 1 commit intomasterfrom
fix-all-the-things
Dec 29, 2015
Merged

Fix all transient test failures#2165
binlijin merged 1 commit intomasterfrom
fix-all-the-things

Conversation

@fjy fjy closed this Dec 28, 2015
@fjy fjy reopened this Dec 28, 2015
@fjy
Copy link
Copy Markdown
Contributor Author

fjy commented Dec 28, 2015

io.druid.curator.announcement.AnnouncerTest
testSessionKilled(io.druid.curator.announcement.AnnouncerTest) Time elapsed: 2.233 sec <<< FAILURE!
java.lang.AssertionError: expected null, but was:<10,10,1451284237249,1451284237249,0,0,0,95111363629613057,25,0,10

at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotNull(Assert.java:664)
at org.junit.Assert.assertNull(Assert.java:646)
at org.junit.Assert.assertNull(Assert.java:656)
at io.druid.curator.announcement.AnnouncerTest.testSessionKilled(AnnouncerTest.java:175)

@fjy fjy closed this Dec 28, 2015
@fjy fjy reopened this Dec 28, 2015
@fjy fjy closed this Dec 28, 2015
@fjy fjy reopened this Dec 28, 2015
@fjy fjy closed this Dec 28, 2015
@fjy fjy reopened this Dec 28, 2015
@fjy fjy closed this Dec 28, 2015
@fjy fjy reopened this Dec 28, 2015
@fjy fjy closed this Dec 28, 2015
@fjy fjy reopened this Dec 28, 2015
@fjy
Copy link
Copy Markdown
Contributor Author

fjy commented Dec 28, 2015

5 straight passes :D

@fjy fjy closed this Dec 28, 2015
@fjy fjy reopened this Dec 28, 2015
@fjy fjy force-pushed the fix-all-the-things branch from 7384a79 to 228238a Compare December 28, 2015 22:21
@fjy fjy closed this Dec 28, 2015
@fjy fjy reopened this Dec 28, 2015
@fjy fjy changed the title [Do not merge] Attempting to find and resolve outstanding transient failures Fix all transient failures Dec 29, 2015
@fjy fjy changed the title Fix all transient failures Fix all transient test failures Dec 29, 2015
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having a timeout here, how about having this never timeout and instead applying a timeout to the test? @Test(timeout = blah). Seems like it would be more robust to have one big timeout than a lot of little timeouts that would be more sensitive to noise.

@fjy fjy force-pushed the fix-all-the-things branch from 80ff24c to dce0990 Compare December 29, 2015 03:52
@fjy fjy force-pushed the fix-all-the-things branch from dce0990 to 38b0f1f Compare December 29, 2015 04:03
@gianm
Copy link
Copy Markdown
Contributor

gianm commented Dec 29, 2015

👍 after travis

binlijin added a commit that referenced this pull request Dec 29, 2015
@binlijin binlijin merged commit 4484d1e into master Dec 29, 2015
@fjy fjy deleted the fix-all-the-things branch December 29, 2015 15:54
@fjy fjy modified the milestone: 0.9.0 Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants