Conversation
Contributor
Author
|
io.druid.curator.announcement.AnnouncerTest
|
Contributor
Author
|
5 straight passes :D |
7384a79 to
228238a
Compare
Contributor
There was a problem hiding this comment.
Instead of having a timeout here, how about having this never timeout and instead applying a timeout to the test? @Test(timeout = blah). Seems like it would be more robust to have one big timeout than a lot of little timeouts that would be more sensitive to noise.
80ff24c to
dce0990
Compare
dce0990 to
38b0f1f
Compare
Contributor
|
👍 after travis |
binlijin
added a commit
that referenced
this pull request
Dec 29, 2015
Fix all transient test failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made all these changes together to make it easier to see if tests are passing or not.
This PR serves to:
SimpleResourceManagementStrategyTest.testProvisionAlert#2147