Simplify information in IncrementalIndex

[navis]

For

private final Map<String, Integer> metricIndexes;
private final Map<String, String> metricTypes;
private final ImmutableList<String> metricNames;

and

private final LinkedHashMap<String, Integer> dimensionOrder;
private final DimensionHolder dimValues;
private final CopyOnWriteArrayList<String> dimensions;

each group can be merged into single map

[fjy]

why change this from metrics?

[navis]

I used metrics for metrics. Ok, I'll revert that.

[fjy]

I'm in favor of this PR but I have some outstanding comments

[drcrallen]

The unofficial convention is to put static classes at the end of class definitions, if I recall from @himanshug 's formatting requests on other PRs

[navis]

ok

[drcrallen]

Very reasonable and easier to read changes. Can you use the getters for the DimensionDesc class fields instead of the fields directly?

[nishantmonu51]

👍

[jon-wei]

👍 Cool PR, looks good to me

[jon-wei]

@navis Can you squash your commits?

[jon-wei]

@navis I'm working on some non-String typing changes to IncrementalIndex, and I want to get this PR in before I submit a PR for that, can you squash the commits if you don't have any more changes?

@fjy @drcrallen @nishantmonu51 I plan on merging this after the squash, do you have any more feedback on this?

[navis]

@jon-wei Squashed

[drcrallen]

is navis@3f0c8cd showing up for anyone else in this PR?

[drcrallen]

yeah, I think @navis you may have grabbed more commits than you meant to.

[jon-wei]

I see that CliPeon commit as well

[navis]

Sorry, my bad.

[navis]

Sorry, my bad.