add ChatHandlerServerModule to realtime example#2189
Merged
fjy merged 1 commit intoapache:masterfrom Jan 4, 2016
pjain1:fix_realtime_example
Merged
add ChatHandlerServerModule to realtime example#2189fjy merged 1 commit intoapache:masterfrom pjain1:fix_realtime_example
fjy merged 1 commit intoapache:masterfrom
pjain1:fix_realtime_example
Conversation
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
Member
|
👍, is there any Unit test that we can add to make sure examples don't get broken in future with other changes ? |
fjy
added a commit
that referenced
this pull request
Jan 4, 2016
add ChatHandlerServerModule to realtime example
Member
Author
|
@nishantmonu51 I cannot think of a way off the top of my head, I will think about it. |
fjy
added a commit
that referenced
this pull request
Jan 26, 2016
[BACKPORT #2189] add ChatHandlerServerModule to realtime example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Realtime Example also need the bindings in this module otherwise it fails to run