trying/finding fix for announcer test failures#2213
Merged
fjy merged 1 commit intoapache:masterfrom Jan 8, 2016
Merged
Conversation
Contributor
|
@himanshug I think you need to uncomment out the test too |
himanshug
force-pushed
the
fix_curtator_test_base
branch
from
297beb9 to
7ab810f
Compare
Contributor
Author
|
@fjy thanks for reminding that :) |
Contributor
Author
|
i have run this build probably more than 10-15 times today and announcer test didn't fail a single time :( |
Contributor
|
@himanshug it can be challenging to reproduce sometimes |
Contributor
Author
|
@fjy despite running this build many many times yesterday and today, I couldn't repro announcer test failure a single time. should we merge this PR and hope to see something useful when the test fails? |
Contributor
|
@himanshug sounds good |
fjy
added a commit
that referenced
this pull request
Jan 8, 2016
[wip] trying/finding fix for announcer test failures
Member
|
@fjy @himanshug any reason this is still tagged as [wip] ? |
himanshug
changed the title
Contributor
|
@xvrl no |
Contributor
Author
|
@xvrl thanks, changed description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
my guess is that curator throws some exception while cleanup and ignoring same leads to visible errors like announcer test failures.
will try build with this patch many times to see if announcer test failure is reproduced and if there is indeed an exception thrown by the cleanup code.
to fix #2167