Segment is not announced somtimes#2268
Closed
navis wants to merge 2 commits intoapache:masterfrom
Closed
Conversation
Member
There was a problem hiding this comment.
minor nit : It will probably be cleaner to create a new SegmentZNode and pass it, instead of the announceSegmentTo creating a new node
Contributor
Author
There was a problem hiding this comment.
I'm using null to decide announce or update in announceSegmentTo().
Contributor
There was a problem hiding this comment.
Can you make a comment as such in the javadoc for the method please?
Member
There was a problem hiding this comment.
ok, +1 for method javadoc.
Member
|
👍 , only minor comments. |
Member
There was a problem hiding this comment.
there's a lot of branching based on segmentNode == null in this method – we might as well have two separate methods
Contributor
|
Duplicated by #2266. As per discussion, we'll merge that one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If all available zone has maxed-out by maxBytesPerNode, it's not announced (from druid-develop).