rename persistBackgroundCount to numBackgroundPersistThreads#2318
Merged
fjy merged 1 commit intoapache:masterfrom Jan 22, 2016
binlijin:rename_persistBackgroundCount
Merged
rename persistBackgroundCount to numBackgroundPersistThreads#2318fjy merged 1 commit intoapache:masterfrom binlijin:rename_persistBackgroundCount
fjy merged 1 commit intoapache:masterfrom
binlijin:rename_persistBackgroundCount
Conversation
Member
|
👍 |
Contributor
|
:+1 after travis |
Member
|
@fjy this PR should not be flagged incompatible, the setting does not exist in any release yet. The previous PR got merged right around when I added my comment. |
fjy
added a commit
that referenced
this pull request
Jan 22, 2016
rename persistBackgroundCount to numBackgroundPersistThreads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @xvrl suggests in #2149.
numBackgroundPersistThreads would be more consistent with our other properties, such as druid.processing.numThreads. We should try to keep property naming consistent.