unit test: adding single threaded indexing and querying test for IncrementalIndex#2324
Merged
fjy merged 1 commit intoapache:masterfrom Jan 23, 2016
Merged
unit test: adding single threaded indexing and querying test for IncrementalIndex#2324fjy merged 1 commit intoapache:masterfrom
fjy merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
👍 |
fjy
added a commit
that referenced
this pull request
Jan 23, 2016
unit test: adding single threaded indexing and querying test for IncrementalIndex
Contributor
There was a problem hiding this comment.
these should be done in a closer or finally block or something to ensure they actually get closed.
Contributor
Author
There was a problem hiding this comment.
i dint go that far becoz they are only working with IncrementalIndex and dint exist previously. That said, you are right and I will take care of this in #2325
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needed this while investigating something else, thought it will be good to keep.