use reverse-iterator if possible#2326
Merged
nishantmonu51 merged 1 commit intoapache:masterfrom Jan 28, 2016
Merged
Conversation
Member
There was a problem hiding this comment.
I didn't notice this earlier, but materializing the integer array might create a lot of heap pressure. Instead, why not copy the bitmap into a temporary roaring bitmap and use its reverse iterator?
Contributor
There was a problem hiding this comment.
we noted this before as well ( https://github.com/druid-io/druid/pull/2014/files#r48668522 ).
navis
force-pushed
the
use-reverse-iterator
branch
from
34591c0 to
b719ee4
Compare
Contributor
|
👍 after squashing commits |
Member
|
👍 once commits are squashed |
navis
force-pushed
the
use-reverse-iterator
branch
from
b719ee4 to
7324ece
Compare
Member
|
👍, will merge once travis passes. |
nishantmonu51
added a commit
that referenced
this pull request
Jan 28, 2016
use reverse-iterator if possible
seoeun25
pushed a commit
to seoeun25/incubator-druid
that referenced
this pull request
Jan 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing missed comments https://github.com/druid-io/druid/pull/2014/files#r49129298