Fixes bug in kill task scheduling DruidCoordinatorSegmentKiller.findIntervalForKillTask()#2346
Merged
nishantmonu51 merged 2 commits intoapache:masterfrom Jan 28, 2016
Merged
Conversation
Contributor
|
@himanshug this fails UT |
Contributor
Author
Contributor
|
👍 |
Member
There was a problem hiding this comment.
could this be replaced with return JodaUtils.umbrellaInterval(usedSegmentIntervals) ?
Contributor
Author
There was a problem hiding this comment.
nice tip, changed.
Contributor
There was a problem hiding this comment.
The return contract on params is ill-defined. Some other methods modify the values in the params before returning them. Can you add a method javadoc describing any intended changes to params, or lack of changes?
Contributor
Author
There was a problem hiding this comment.
ok, added javadoc.
Contributor
|
👍 after travis |
Member
|
👍 |
nishantmonu51
added a commit
that referenced
this pull request
Jan 28, 2016
Fixes bug in kill task scheduling DruidCoordinatorSegmentKiller.findIntervalForKillTask()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.