Skip to content

new local lru cache#2351

Closed
binlijin wants to merge 1 commit intoapache:masterfrom
binlijin:newLocalCache
Closed

new local lru cache#2351
binlijin wants to merge 1 commit intoapache:masterfrom
binlijin:newLocalCache

Conversation

@binlijin
Copy link
Copy Markdown
Contributor

When we set Historical cache to the flowing Configuration

druid.cache.type=local
druid.cache.sizeInBytes=2000000000 //almost 2G

we find the historical have 5.6G of cache data.

And when we change to

druid.cache.type=local
druid.cache.sizeInBytes=500000000 //almost 500M

we find the historical have 2G of cache data.

Historical cache data is larger than the configured druid.cache.sizeInBytes.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any guard to prevent size from being 0?

@drcrallen
Copy link
Copy Markdown
Contributor

This will need to be reconciled with #1849

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this default to the number of processing threads?

@xvrl
Copy link
Copy Markdown
Member

xvrl commented Jan 29, 2016

@binlijin did you look at what I did in #1849 before working on this?
My experience is that guava cache might have worse latencies, that's why I haven't been gung ho on getting #1849 merged.

@drcrallen
Copy link
Copy Markdown
Contributor

Also note #1836

There seem to be a few outstanding issues with the caching done currently that are not called out here:

  1. Latency of guava cache
  2. Benchmarks on concurrent access
  3. Improvements (or no change) on behavior of large single-scans clobbering the cache.

@binlijin
Copy link
Copy Markdown
Contributor Author

@drcrallen @xvrl thanks, i will have a look at them,and others should hold on this.

@binlijin binlijin closed this Mar 9, 2016
seoeun25 pushed a commit to seoeun25/incubator-druid that referenced this pull request Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants