new local lru cache#2351
Closed
binlijin wants to merge 1 commit intoapache:masterfrom
binlijin:newLocalCache
Closed
new local lru cache#2351binlijin wants to merge 1 commit intoapache:masterfrom binlijin:newLocalCache
binlijin wants to merge 1 commit intoapache:masterfrom
binlijin:newLocalCache
Conversation
Contributor
There was a problem hiding this comment.
is there any guard to prevent size from being 0?
Contributor
|
This will need to be reconciled with #1849 |
Contributor
There was a problem hiding this comment.
Can this default to the number of processing threads?
Member
Contributor
|
Also note #1836 There seem to be a few outstanding issues with the caching done currently that are not called out here:
|
Contributor
Author
|
@drcrallen @xvrl thanks, i will have a look at them,and others should hold on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we set Historical cache to the flowing Configuration
we find the historical have 5.6G of cache data.
And when we change to
we find the historical have 2G of cache data.
Historical cache data is larger than the configured druid.cache.sizeInBytes.