[WIP] segment management using HTTP Endpoints#2368
Closed
nishantmonu51 wants to merge 4 commits intoapache:masterfrom
Closed
[WIP] segment management using HTTP Endpoints#2368nishantmonu51 wants to merge 4 commits intoapache:masterfrom
nishantmonu51 wants to merge 4 commits intoapache:masterfrom
Conversation
Member
Author
|
@guobingkun @drcrallen: Since you are working on similar area, Can you guys do the initial review and provide feedback ? |
Contributor
There was a problem hiding this comment.
suggest being more descriptive like startStopLock
Contributor
|
A lot of places seem to be implementing ListenableFutures by hand. Is it reasonable to change the callback stuff to be ListenableFutrue callbacks? |
Contributor
There was a problem hiding this comment.
parameters should be flipped i think
Contributor
|
@nishantmonu51 are you still planning to work on this? if not, then I can take it up. thanks. |
Contributor
|
@nishantmonu51 ping! |
Contributor
|
@nishantmonu51 I'm closing this PR and will submit another to support optional segment assignment to http. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes for Proposal - #2314
This PR abstracts out zookeeper interactions in the historical and coordinator for segment management.
Changes in Historical Nodes -
Changes in Coordinator -
TODO: