Add support for Long and Float numeric dimensions (without indexing)#2442
Closed
jon-wei wants to merge 2 commits intoapache:masterfrom
Closed
Add support for Long and Float numeric dimensions (without indexing)#2442jon-wei wants to merge 2 commits intoapache:masterfrom
jon-wei wants to merge 2 commits intoapache:masterfrom
Conversation
This was referenced Feb 11, 2016
abbd914 to
440a12e
Compare
440a12e to
d60a780
Compare
Contributor
|
@jon-wei this is failing UT |
Contributor
Author
|
@fjy This PR won't be able to pass UT as-is, it depends on a change to DimensionsSpec in druid-api: I'm opening it now to get the review process started |
Contributor
Author
|
Based on a discussion with @gianm this afternoon, I'm looking into abstracting out a generic/extensible "dimension handling" interface across the IncrementalIndex/IndexMerger/querying paths. Will update this PR as I make progress. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Long and Float numeric dimensions.
It depends on the following two PRs:
Implementation notes:
Unit test notes: