Skip to content

Fix for unstable behavior of HyperLogLog comparator #2453

Merged
gianm merged 1 commit intoapache:masterfrom
DreamLab:fix/topn_sorting_anomaly
Feb 12, 2016
Merged

Fix for unstable behavior of HyperLogLog comparator #2453
gianm merged 1 commit intoapache:masterfrom
DreamLab:fix/topn_sorting_anomaly

Conversation

@turu
Copy link
Copy Markdown
Contributor

@turu turu commented Feb 11, 2016

Fixes #2447

@fjy
Copy link
Copy Markdown
Contributor

fjy commented Feb 11, 2016

@turu awesome catch. Do you mind trying the @ignore methods in HyperLogLogCollectorTest.java before and after the patch to verify performance?

@turu
Copy link
Copy Markdown
Contributor Author

turu commented Feb 11, 2016

@fjy thanks :).

Here are the results (avg from 3 runs on my machine) for the ignored long running tests in HyperLogLogCollectorTest.java:
Before patch (at current tip of master):

  1. testHighCardinalityRollingFold - 62s 583ms
  2. testHighCardinalityRollingFold2 - 109s 594ms
    After patch:
  3. testHighCardinalityRollingFold - 62s 882ms
  4. testHighCardinalityRollingFold2 - 109s 513ms

@xvrl
Copy link
Copy Markdown
Member

xvrl commented Feb 11, 2016

Thanks for the awesome bug report @turu we don't get many of those. 👍 on merging this from my end.

@gianm
Copy link
Copy Markdown
Contributor

gianm commented Feb 12, 2016

👍

gianm added a commit that referenced this pull request Feb 12, 2016
Fix for unstable behavior of HyperLogLog comparator
@gianm gianm merged commit 2d037ef into apache:master Feb 12, 2016
@gianm gianm added the Bug label Feb 12, 2016
@fjy fjy added this to the 0.9.0 milestone Feb 12, 2016
@fjy
Copy link
Copy Markdown
Contributor

fjy commented Feb 12, 2016

@xvrl @gianm we should backport this

@turu
Copy link
Copy Markdown
Contributor Author

turu commented Feb 12, 2016

Thanks for a swift reaction guys 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants