Consolidate argument type of extraction function#2471
Closed
navis wants to merge 2 commits intoapache:masterfrom
Closed
Consolidate argument type of extraction function#2471navis wants to merge 2 commits intoapache:masterfrom
navis wants to merge 2 commits intoapache:masterfrom
Conversation
navis
force-pushed
the
consolidate-extration-function
branch
from
03b57f2 to
082cec1
Compare
Contributor
Author
There was a problem hiding this comment.
It's not used, just made for completeness. Can be removed.
navis
force-pushed
the
consolidate-extration-function
branch
from
082cec1 to
14a7ea6
Compare
navis
force-pushed
the
consolidate-extration-function
branch
from
14a7ea6 to
678b6ba
Compare
navis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another proposal for extraction function. #2405 suggested to have multiple apply method for each type but this one is for making a single apply method with Object type parameter. Related to #2263.