Add comparator to HyperUniquesFinalizingPostAggregator.#2496
Merged
fjy merged 1 commit intoapache:masterfrom Feb 19, 2016
Merged
Add comparator to HyperUniquesFinalizingPostAggregator.#2496fjy merged 1 commit intoapache:masterfrom
fjy merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
👍 |
Contributor
|
Is this a regression or a long standing bug? |
Contributor
Author
|
@drcrallen I believe it is long standing |
Contributor
There was a problem hiding this comment.
instead of handling nulls explicitly, suggest using Ordering with nullsLast
gianm
force-pushed
the
hll-finalizing-comparator
branch
from
f138f2c to
aa0ef74
Compare
Contributor
Author
|
@drcrallen updated with your comments addressed, could you take another look? |
This makes it possible to do groupBys with clauses like "HAVING uniques > 10". Beforehand you couldn't do it with either an aggregator (because it returns an HLLV1 which the havingSpec can't understand) or a finalized postaggregator (because it didn't have a comparator). Now you can at least do it with a finalizing postaggregator. Trying it with the aggregator alone still doesn't work. Added some topN and groupBy tests verifying the comparator, and added an @ignore test that should pass if havingSpecs are made work on the aggregator directly.
gianm
force-pushed
the
hll-finalizing-comparator
branch
from
aa0ef74 to
d25c46c
Compare
Contributor
Author
|
also filed issue #2507 for the op that still does not work even after this fix. |
Contributor
|
Cool 👍 |
fjy
added a commit
that referenced
this pull request
Feb 19, 2016
Add comparator to HyperUniquesFinalizingPostAggregator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to do groupBys with clauses like "HAVING uniques > 10".
Beforehand you couldn't do it with either an aggregator (because it returns
an HLLV1 which the havingSpec can't understand) or a finalized postaggregator
(because it didn't have a comparator).
Now you can at least do it with a finalizing postaggregator. Trying it with
the aggregator alone still doesn't work.
Added some topN and groupBy tests verifying the comparator, and added an
@Ignoretest that should pass if havingSpecs are made work on the aggregatordirectly.