Skip to content

Add option for select query to get next page without modifying returned paging identifiers#2576

Merged
fjy merged 1 commit intoapache:masterfrom
navis:paging-from-next
Apr 1, 2016
Merged

Add option for select query to get next page without modifying returned paging identifiers#2576
fjy merged 1 commit intoapache:masterfrom
navis:paging-from-next

Conversation

@navis
Copy link
Copy Markdown
Contributor

@navis navis commented Mar 2, 2016

Select query returns page identifiers which can be used to get next page of returned value. But before sending it back, we need to increment or decrement offsets by hand.

I've tried returning identifiers for next page. But this way was a lot simpler.

@fjy
Copy link
Copy Markdown
Contributor

fjy commented Mar 2, 2016

This is great

@jaehc
Copy link
Copy Markdown
Contributor

jaehc commented Mar 3, 2016

This looks very useful.

Comment thread docs/content/querying/select-query.md Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think for next major release, fromNext should be on by default

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets create an issue to track this and mark it for 0.10.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done (see #2767)

@nishantmonu51 nishantmonu51 self-assigned this Mar 28, 2016
@nishantmonu51
Copy link
Copy Markdown
Member

👍

@navis navis force-pushed the paging-from-next branch 2 times, most recently from 024a535 to 33d3aa8 Compare March 31, 2016 23:58
@navis navis force-pushed the paging-from-next branch from 33d3aa8 to 29bb005 Compare April 1, 2016 00:07
@fjy fjy merged commit eea7a47 into apache:master Apr 1, 2016
@xvrl xvrl added this to the 0.9.1 milestone Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants