Use ImmutableWorkerInfo instead of ZKWorker#2588
Conversation
|
@gianm @drcrallen: Since its mostly related to your changes, please have a look at it. |
|
@nishantmonu51 looks good other than some minor comments, let me know when you are ready and I can take another look |
b7d1896 to
87203d8
Compare
|
@drcrallen @gianm handed review comments, please check again. |
review comments add test for equals and hashcode
87203d8 to
9cceff2
Compare
|
👍 after travis |
|
Tests run: 5, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 34.79 sec <<< FAILURE! - in io.druid.indexing.worker.WorkerTaskMonitorTest |
| * Once a task completes, it is up to the RTR to remove the task status and run any necessary cleanup. | ||
| * The RemoteTaskRunner is event driven and updates state according to ephemeral node changes in ZK. | ||
| * <p/> | ||
| * <p> |
There was a problem hiding this comment.
did these doc changes need to happen?
There was a problem hiding this comment.
its done by intellij with the code formatting. so probably its fine to go along.
|
👍 (after travis) minor question about javadoc at author's discretion. |
Use ImmutableWorkerInfo instead of ZKWorker
This PR is follow up changes for #2249 and #2585
#2249 uses Worker instead of ZkWorker whenever possible for task tiering.
This PR changes the behavior to expose ImmutableWorkerInfo from WorkerTaskRunner instead of Worker. ImmutableWorkerInfo has more details like list of running tasks and availability groups.
These extra details exposed are required for #2086 (implementing pending task based resource management strategy)