Support use of DimensionSchema class in DimensionsSpec#2607
Support use of DimensionSchema class in DimensionsSpec#2607himanshug merged 1 commit intoapache:masterfrom
Conversation
|
I have a much larger PR that I am cleaning up right now that adds Long/Float support along with a new generic dimension handling interface. I'm opening this PR now to cut down the size of that later patch, for easier review. |
jon-wei
force-pushed
the
dim_schema
branch
2 times, most recently
from
48ebf4d to
63077f0
Compare
There was a problem hiding this comment.
nit: can "spatial" be made a static final variable in DimensionSchema ?
There was a problem hiding this comment.
@himanshug updated this and the other patch with static finals
|
@jon-wei could you take a look at the compilation failures? |
|
@jon-wei or are these expected due to not having the new druid-api yet? |
|
nevermind, they're definitely expected. |
There was a problem hiding this comment.
it is gonna be hella confusing to understand what is a dim or metric here, can we distinguish them some other way?
There was a problem hiding this comment.
@fjy Changed this to an Object -> ValueType map with comments explaining the use cases
|
@jon-wei mostly looks good, only 1 comment can we also update druid-api version in this PR? |
jon-wei
force-pushed
the
dim_schema
branch
2 times, most recently
from
3962d6b to
e07f8e4
Compare
|
@fjy updated druid-api to 3.17 in the pom |
|
👍 |
|
@jon-wei this is sitll failing UT |
|
@fjy rebased, should pass travis now |
Support use of DimensionSchema class in DimensionsSpec
4 participants
Updates druid to support the change made in this druid-api PR: https://github.com/druid-io/druid-api/pull/75/files
Needs druid-api version update after that PR is merged
The DimensionsSpec object now represents dimensions with a DimensionSchema class, not as String names, to support additional dimension types.