Update com.maxmind.geoip2 to 2.6.0#2646
Merged
nishantmonu51 merged 1 commit intoapache:masterfrom Mar 14, 2016
Merged
Conversation
com.maxmind.geoip2 2.6.0 depends on com.google.http-client 1.15.0-rc (3 years old). When trying to include other libraries in Druid that require an up to date version of com.google.http-client this causes a problem.
Member
|
👍 |
1 similar comment
Member
|
👍 |
nishantmonu51
added a commit
that referenced
this pull request
Mar 14, 2016
Update com.maxmind.geoip2 to 2.6.0
This was referenced Mar 15, 2016
Merged
gianm
added a commit
to gianm/druid
that referenced
this pull request
Mar 25, 2016
Reverts "Update com.maxmind.geoip2 to 2.6.0" and exclude the google http client from com.maxmind.geoip2. This should satisfy the original need from apache#2646 (wanting to run Druid along with an upgraded com.google.http-client) while preventing Jackson conflicts pointed out in apache#2717. Fixes apache#2717. This reverts commit 21b7572.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
com.maxmind.geoip22.6.0depends oncom.google.http-client1.15.0-rc(3 years old).When trying to include other libraries in Druid that require an up to date version of
com.google.http-clientthis causes a problem.I am not sure if I should include
com.maxmind.dbin the Druid pom.xml file as I import something from it.com.maxmind.geoip2already depends on it so I guess it's not necessary?