Filters: Add filter.toFilter method, use that instead of the instanceof chain in Filters.#2713
Merged
fjy merged 1 commit intoapache:masterfrom Mar 24, 2016
Merged
Conversation
Contributor
Author
|
This should make it possible to do Filters as an extension, like #2613 wants to do. |
Contributor
|
👍 |
Contributor
|
@gianm sound merge confclits with your other PR |
gianm
force-pushed
the
filter-extensions
branch
from
fa0e12c to
2644160
Compare
Contributor
Author
|
repaired conflicts |
Contributor
There was a problem hiding this comment.
Should we throw an exception instead if a DimFilter was null?
Contributor
|
Had 1 comment/question on null DimFilter handling, but 👍 after travis aside from that |
…of chain in Filters. I believe that the instanceof chain in Filters exists because in the past, Filter and DimFilter were in different packages (DimFilter was in druid-client and Filter was in druid-processing). And since druid-client didn't depend on druid-processing, DimFilter couldn't have a toFilter method. But now it can.
gianm
force-pushed
the
filter-extensions
branch
from
2644160 to
7130620
Compare
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe that the instanceof chain in Filters exists because in the past, Filter
and DimFilter were in different packages (DimFilter was in druid-client and Filter
was in druid-processing). And since druid-client didn't depend on druid-processing,
DimFilter couldn't have a toFilter method. But now it can.