Fix predicate-based ValueMatcher behavior for IncrementalIndex on missing columns.#2737
Merged
jon-wei merged 1 commit intoapache:masterfrom Mar 25, 2016
Merged
Conversation
…sing columns. Missing columns should be treated the same as columns containing 100% nulls.
Contributor
|
@gianm is there a unit test that can be added for such a case? |
Contributor
Author
|
@drcrallen #2727 has some tests that do hit this case (in new test files), I didn't include them here since they were already in that one. this is one of them: https://github.com/druid-io/druid/pull/2727/files#diff-fcf344c7211cdbe0c45d06ec5ade158aR135 |
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing columns should be treated the same as columns containing 100% nulls.
No tests in this PR, but #2727 contains some tests that do catch this as part of a new set of filter tests. (that's how I noticed it)