Fix LookupCoordinatorManager and Test for alerts#2743
Merged
fjy merged 1 commit intoapache:masterfrom Mar 28, 2016
Merged
Conversation
Contributor
drcrallen
commented
Mar 26, 2016
drcrallen
commented
- Fixes test that missed https://github.com/druid-io/druid/pull/2741/files#r57495018
- Also fixes spurious alerting on Lookup delete success
drcrallen
force-pushed
the
fixlookuptest
branch
from
80c20ed to
b78dda8
Compare
Contributor
|
@drcrallen this fails UT |
drcrallen
force-pushed
the
fixlookuptest
branch
from
b78dda8 to
ccd3b7b
Compare
* Also fixes bad alerting on missing nodes
drcrallen
force-pushed
the
fixlookuptest
branch
from
ccd3b7b to
05151bc
Compare
drcrallen
changed the title
| manager.updateAllOnTier(LOOKUP_TIER, SINGLE_LOOKUP_MAP); | ||
| SERVICE_EMITTER.flush(); | ||
| Assert.assertEquals(1, EVENT_EMITS.get()); | ||
| EVENT_EMITS.set(0); |
Contributor
There was a problem hiding this comment.
this happens in setUp so should not be necessary here
Contributor
Author
There was a problem hiding this comment.
This is for tearDown when it checks that there are 0 events.
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.