Conversation
|
@navis we should add tests for this. |
| * https://github.com/druid-io/druid/issues/2011 | ||
| */ | ||
| public void loadDimensionIterable(Iterable<String> oldDimensionOrder) | ||
| public void loadDimensionIterable(Map<String, ColumnCapabilities> oldDimensionOrder) |
There was a problem hiding this comment.
minor nit: rename method to loadDimensions
|
looks good to me, please add tests. |
|
@xvrl @nishantmonu51 I tried but cannot make some meaningful tests, not yet because all dimensions are still string type. I think we should wait for progress of numeric type dimensions. |
|
waiting #2760 |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@druid.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
3 participants
column names are propagated but capabilities are not. just a refactoring for consistency.