Merged
Conversation
| @@ -0,0 +1,123 @@ | |||
| package io.druid.server; | |||
Contributor
|
This looks great. |
Member
|
I'm of course 👍 on this one, but since I was involved I'd prefer if we get two other +1 on this one |
Contributor
|
👍 needs 1 more |
Contributor
|
LGTM, It will be nice if we add some unit tests to cover the new class. |
Member
|
👍 , LGTM, @jisookim0513: minor nit, could you also modify QueryRunnerTestHelper.makeXXXQueryRunner to use the new api ? |
Contributor
Author
|
@nishantmonu51 sure, I will modify QueryRunnerTestHelper to use the new API. |
Contributor
|
👍 |
Contributor
Author
|
@nishantmonu51: modified QueryRunnerTestHelper and refactored FluentQueryRunnerBuiler not to take query as a constructor argument (also moved it to druid.io.processing from druid.io.server) |
Member
|
👍 on the latest changes. |
seoeun25
pushed a commit
to seoeun25/incubator-druid
that referenced
this pull request
Jan 10, 2020
…rtitioned table in hive path spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been working on using Spark for long-running Druid queries. I was able to run a long-running druid query without timeout by having intermediate-level brokers that process the query for a specific chunk of segments and letting the final broker merge the query results from intermediate brokers. While doing so, I had to write my own query runners where one does stuff from
RetryQueryRunnertotoolChest.mergeResultsand the other does stuff fromtoolChest.mergeResultstoFinalizeResultsQueryRunner. @xvrl suggested refactoringClientQuerySegmentWalkerthis way so I can use the methods from a new class instead of reusing the code fromClientQuerySegmentWalker.