Allow user to set cost balancer threads more than or equal to the number of cores.#2964
Merged
himanshug merged 2 commits intoapache:masterfrom May 13, 2016
Merged
Conversation
Allow user to set cost balancer threads more than the number of cores.
nishantmonu51
changed the title
Member
|
👍 |
Contributor
|
👍 for the code change |
Member
|
@himanshug the current code caps at cores - 1, which is a problem for us when we have 2 cores |
Member
|
we currently spend most of our time doing those cost calculations, so being able to use all cores is beneficial |
Contributor
|
ok so you really want to set num to be equal to cores not more than that really, that makes sense. |
xvrl
pushed a commit
to metamx/druid
that referenced
this pull request
May 18, 2016
…ber of cores. (apache#2964) * Allow user to set cost balancer threads more than the number of cores. Allow user to set cost balancer threads more than the number of cores. * modify test
drcrallen
added a commit
to metamx/druid
that referenced
this pull request
May 18, 2016
Backport balancing improvements apache#2910 apache#2964 apache#2972
seoeun25
pushed a commit
to seoeun25/incubator-druid
that referenced
this pull request
Jan 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow user to set cost balancer threads more than or equal to the number of cores.
FWIW, I am unable to set balancer threads to 4 on a machine having 2 cpu cores.