Move QueryGranularity static fields to QueryGranularities#2980
Merged
fjy merged 3 commits intoapache:masterfrom May 17, 2016
Merged
Move QueryGranularity static fields to QueryGranularities#2980fjy merged 3 commits intoapache:masterfrom
fjy merged 3 commits intoapache:masterfrom
Conversation
Contributor
|
I like the name QueryGranularities better than QueryGranularityUtil but otherwise 👍 |
Contributor
Author
|
Added a test which showcases the bug. I can switch the class from util --> granularities. give me 1 sec |
Contributor
Author
|
marking as incompatible because it may require extensions to change their class |
drcrallen
changed the title
Contributor
|
👍 |
fundead
pushed a commit
to fundead/druid
that referenced
this pull request
Oct 4, 2016
sirpkt
added a commit
to sirpkt/druid
that referenced
this pull request
Dec 16, 2016
leventov
reviewed
Jun 15, 2017
| { | ||
| final URL[] urls = ((URLClassLoader)QueryGranularity.class.getClassLoader()).getURLs(); | ||
| final String className = QueryGranularity.class.getCanonicalName(); | ||
| for(int i = 0; i < 1000; ++i) { |
Member
There was a problem hiding this comment.
@drcrallen do you remember why you added 1000 iterations here? Was it necessary to catch a deadlock?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only QueryGranularity and QueryGranularities changed here.
All the rest of the changes are simple class name changes for the static fields