fix possible 'Null storage adapter found' when segments are swapped#2981
Closed
xvrl wants to merge 1 commit intoapache:masterfrom
Closed
fix possible 'Null storage adapter found' when segments are swapped#2981xvrl wants to merge 1 commit intoapache:masterfrom
xvrl wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
@xvrl the old code doesn't look buggy to me; queries get Segments from getAndIncrementSegment which is synchronized with swapSegment. If a query had got the Segment, then the "close" in swapSegment will just decrement the refcount, not actually close the segment. |
Contributor
|
do you have a stack trace of the error you're seeing? |
Member
Author
|
my bad, this issue was already fixed in #2301 and was just looking at some old logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was possible for a query to get a closed adapter before the new one was put in place.